Rails hydra#57
Closed
tpickett66 wants to merge 46 commits into
Closed
Conversation
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
I generated using 3.2.8 but it includes many features not available in older versions. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Since the dummy app is handling this now we don't need to maintain these setup methods. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Because such a huge shift was made between rails 2.3 and 3.x we can't use the same boot process. There will be more hacks to make this work... Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
This approach only works in Rails 2.3 so it doesn't further the goal of adding 3.x support but it may provide a path forward. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Because Rails 2.3 and 3.x handle sessions differently we need to get a controller instance in a slightly different way between them. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Hooray! These two specs are green in all target versions of Rails! (2.3, 3.0, 3.1, 3.2) Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
This way we can quickly find everything using it. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Rails 3.x mangles this method in some weird way. The specs were failing at line 32 of storage.rb where we were trying to use the session_class method on the session store, in the debugger using send didn't work but using session_class.superclass.find_by_session_id did work so we arrive at this stupid simple implementation Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time of this request we don't have any support for Rails 3.X in the client and rubycas-client-rails doesn't work with the latest version of the client gem. So to start the process of bringing Rails 3.x support (and incidentally Ruby 1.9..3) I began the process of moving the test infrastructure to using a dummy app. To maintain Rails 2.3 testability there were a lot of hacks that had to be done but most of the commits here only touch a few files so they should be easy to digest.