Skip to content

Remove rails method 'blank?' #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elspethsoup merged 1 commit into from
Mar 10, 2014
Merged

Remove rails method 'blank?' #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/casclient/responses.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def initialize(raw_text, options={})

def parse(raw_text, options)
raise BadResponseException,
"CAS response is empty/blank." if raw_text.blank?
"CAS response is empty/blank." if raw_text.to_s.empty?
@parse_datetime = Time.now
if raw_text =~ /^(yes|no)\n(.*?)\n$/m
@protocol = 1.0
Expand Down Expand Up @@ -89,7 +89,7 @@ def parse(raw_text, options)
end

def parse_extra_attribute_value(value, encode_extra_attributes_as)
attr_value = if value.blank?
attr_value = if value.to_s.empty?
nil
elsif !encode_extra_attributes_as
begin
Expand Down Expand Up @@ -140,7 +140,7 @@ def initialize(raw_text, options={})

def parse(raw_text)
raise BadResponseException,
"CAS response is empty/blank." if raw_text.blank?
"CAS response is empty/blank." if raw_text.to_s.empty?
@parse_datetime = Time.now

@xml = check_and_parse_xml(raw_text)
Expand Down Expand Up @@ -214,7 +214,7 @@ def parse_http_response(http_response)
end

def is_success?
!@failure && !ticket.blank?
!@failure && !ticket.to_s.empty?
end

def is_failure?
Expand Down