Remove rails method 'blank?' #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can remove usage of blank, but the implementation you provided will error when the values are nil. ActiveSupport's blank? will return true on nil. |
Contributor
Author
|
No, it's working, try the following code in the irb: nil.to_s.empty? |
Member
|
I stand corrected. It works as you say. |
elspethsoup
added a commit
that referenced
this pull request
Mar 10, 2014
Remove rails method 'blank?'
Contributor
Author
|
Awesome, thanks for merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using rubycas-client without rails. The method 'blank?' is only available in the rails environment.
This pull request removes this requirement and allows us to use rubycas without adding the blank method to 'Object'.