Username postfix for ldap_authenticators#166
Merged
tpickett66 merged 2 commits intorubycas:masterfrom May 3, 2013
swobspace:ldap_username_postfix
Merged
Username postfix for ldap_authenticators#166tpickett66 merged 2 commits intorubycas:masterfrom swobspace:ldap_username_postfix
tpickett66 merged 2 commits intorubycas:masterfrom
swobspace:ldap_username_postfix
Conversation
|
Hi, thanks a lot but could you rebase it and squash to one commit? |
tpickett66
added a commit
that referenced
this pull request
May 3, 2013
Username postfix for ldap_authenticators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldap.rb has a username_prefix, but no username_postfix.
Scenario:
We use authentication based on the userprincipalname (an active directory attribute). Our userprincipalnames follows the syntax user@sub.domain.com. But we use only a partial for login: user@sub. In our large organisation there may be identical samaccountnames in different subdomains like smith@sub1 and smith@sub2.
If we can use a username_postfix = '.domain.com', all works fine: the user can use the short form and the authentication uses the full userprincipalname.