Skip to content

Use cliver from github for tests#211

Merged
route merged 6 commits intomasterfrom
cliver-master
Oct 26, 2021
Merged

Use cliver from github for tests#211
route merged 6 commits intomasterfrom
cliver-master

Conversation

@route
Copy link
Copy Markdown
Member

@route route commented Oct 26, 2021

No description provided.

@route route merged commit ed94512 into master Oct 26, 2021
@route route deleted the cliver-master branch October 26, 2021 09:40
@zw963
Copy link
Copy Markdown
Contributor

zw963 commented Nov 1, 2021

Hi, do you consider remove cliver gem? anyway, this gem never update since 7 years ago, and i search code on ferrum,

ferrum/browser/options/base.rb:31:              path = Cliver.detect(name) and break(path)
ferrum/browser/command.rb:32:        raise Cliver::Dependency::NotFound.new(NOT_FOUND) unless @path
ferrum/browser/xvfb.rb:14:        Cliver.detect("Xvfb")
ferrum/browser/xvfb.rb:21:        raise Cliver::Dependency::NotFound.new(NOT_FOUND) unless @path

is there some special use case for must use cliver gem resolve this?

@zw963
Copy link
Copy Markdown
Contributor

zw963 commented Nov 1, 2021

BTW: when run test on it, i get following warning too.

gems/cliver-0.3.2/lib/core_ext/file.rb:15: warning: method redefined; discarding old absolute_path?

@route
Copy link
Copy Markdown
Member Author

route commented Nov 1, 2021

@zw963 Yes I think we can remove it, though we need to first write a simple replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants