fix: [#583] Don't raise timeout on lazy iframes#597
Merged
Conversation
Chrome fires `Page.frameAttached` for every iframe in the DOM, but only fires `Page.frameStoppedLoading` for frames it actually loads. For a loading="lazy" iframe parked outside the viewport (e.g. inside a closed <details>, or injected by an inline <script> during page parse), Chrome never starts loading it, so it never transitions to :started_loading or :stopped_loading. It stays at state nil indefinitely. With this PR we are utilizing `Page.setLifecycleEvents` for frame network idle detection that helps to mark such frames as :stopped_loading.
route
force-pushed
the
583-fix-lazy-iframes
branch
from
a999a17 to
885733a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome fires
Page.frameAttachedfor every iframe in the DOM, but only firesPage.frameStoppedLoadingfor frames it actually loads. For a loading="lazy" iframe parked outside the viewport (e.g. inside a closedDetails
, or injected by an inline <script> during page parse), Chrome never starts loading it, so it never transitions to :started_loading or :stopped_loading. It stays at state nil indefinitely. With this PR we are utilizingPage.setLifecycleEventsfor frame network idle detection that helps to mark such frames as :stopped_loading.