Add informations about upcoming and past meetups#1526
Add informations about upcoming and past meetups#1526ChaelCodes merged 6 commits intorubyevents:mainfrom
Conversation
|
The weird thing about meetup events is that they don't have dates. One event represents every meetup. There's a branch to refactor that, but it's not done yet. |
|
Interesting, does it make sense this upcoming meetups count? |
|
I don't think it does. I think the missing date is why all meetups are showing up in the past. You could look at videos to get upcoming and past events, but I'm not sure if there are any meetups that input upcoming events into RubyEvents. This is more of a current data issue than a usability concern though. @hschne - I'd be curious to hear your perspective on this one. You're really active on RubyEvents and Vienna.rb only shares past events. |
|
I'm not 100% sure if I understand correctly, but I do put in Vienna.rb meetups as soon as they are scheduled - so they would qualify as upcoming, and I would love for those to shop up somewhere. The fact that they don't have a date IMO is the data issue you described and should (?) be solved by the new data structure (one event per meetup) I think? |
|
Agreed. If meet-ups with upcoming editions in their videos.yml show more prominently on the site that's an incentive for meet-ups to add the data for future events. |
viniciusalonso
force-pushed
the
upcoming-meetups
branch
from
de5618b to
4bcf493
Compare
|
I've changed the scopes |
|
Shouldn't it be date rather than published_at? published_at is the date the YouTube video was published if applicable which might be after the event |
|
@matthewmayer good catch! Fixed |
|
i noticed nearly every meetup in the preview section incorrectly shows "Takes place today" 
Can this easily be fixed together with this change? |
|
It looks easy to fix, but I'd prefer to do it in a new PR. This one is taking longer than I expected 😂 I will send a new PR with this fix tonight. 
|
| } | ||
|
|
||
| scope :upcoming_meetups, -> { | ||
| joins(:talks).where(kind: :meetup, talks: {date: nil}).distinct |
There was a problem hiding this comment.
Talks always have a date.
rubyevents/app/schemas/video_schema.rb
Line 64 in 3f3402b
I think we want a range for this one too.
Sorry for the confusion. I was looking for some clarity around the use case. You're one of the most active meetup organizers I know on the site and when I checked Vienna.rb only had past ones. My thinking was that if we only have past meetups at the moment, it might be better to defer this until after the meetups refactor, because they'll all be past anyway. But it sounds like there is interest in upcoming meetups, and I see that Ruby Tuesday has one on March 31st, so we'll have at least one. |
Hey @matthewmayer, I created a PR for this one #1547 |
ChaelCodes
left a comment
ChaelCodes
left a comment
There was a problem hiding this comment.
Thanks for this! Sorry for all the back-and-forth. The meetups page looks much nicer now.
|
Oh no! There's a merge conflict. |
@ChaelCodes fixed :) |
|
@viniciusalonso Thank you!! |
4 participants
Description
Add informations about upcoming and past meetups
Screenshots
Testing Steps
References