hex colors must include ##1538
Merged
ChaelCodes merged 2 commits intorubyevents:mainfrom Mar 17, 2026
Merged
Conversation
Collaborator
|
I can't tell you why - but this appears to be intentional. rubyevents/lib/tasks/event_assets.rake Lines 329 to 332 in 501652a Either that or there's a data issue happening in the generator that needs to be resolved. |
Member
|
I think the rake task is actually wrong |
Collaborator
|
If that's the case, we should fix the generate event assets rake task to remove deleting the #. rubyevents/lib/tasks/event_assets.rake Lines 329 to 332 in 501652a |
ChaelCodes
approved these changes
Mar 17, 2026
Collaborator
ChaelCodes
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing this @matthewmayer ! Appreciate you finding all the edge cases.
Collaborator
|
We can capture this with a pattern too - https://github.com/danielfriis/ruby_llm-schema?tab=readme-ov-file#strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1537