Fix "Notifications is invalid" error when editing workshop logs#1145
Merged
Fix "Notifications is invalid" error when editing workshop logs#1145
Conversation
Remove broken after_save :create_notification callback from Report that created notifications with only notification_type, missing required kind, recipient_role, and recipient_email fields. Add autosave: false to the notifications association since notifications are created explicitly via NotificationServices::CreateNotification. Also remove commented-out duplicate pattern in users_controller. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Remove broken after_save :create_notification callback from Report that created notifications with only notification_type, missing required kind, recipient_role, and recipient_email fields. Add autosave: false to the notifications association since notifications are created explicitly via NotificationServices::CreateNotification. Also remove commented-out duplicate pattern in users_controller.