Skip to content

HOLD UNTIL READY TO LAUNCH: Allow authenticated users to access the people index and search#1494

Draft
maebeale wants to merge 1 commit into
mainfrom
maebeale/people-index-authenticated
Draft

HOLD UNTIL READY TO LAUNCH: Allow authenticated users to access the people index and search#1494
maebeale wants to merge 1 commit into
mainfrom
maebeale/people-index-authenticated

Conversation

@maebeale
Copy link
Copy Markdown
Collaborator

What is the goal of this PR and why is this important?

  • Open up the People index (GET /people) and people typeahead search to all authenticated users
  • Previously both were admin-only; we want regular users to be able to find other community members
  • Visibility filters that govern which people show up (searchable flag, active affiliations, locked user accounts) are tracked separately — see follow-up PR Hide locked users' profiles from the non-admin people index #1489

How did you approach the change?

  • PersonPolicy#index? and PersonPolicy#search? now allow any authenticated user instead of only admins
  • The existing non-admin relation_scope already filters to searchable people with active affiliations, so non-admins still don't see opted-out profiles or people with no active affiliation
  • show?, edit?, update?, and destroy? remain admin-only (or owner for show?)
  • Updated the PersonPolicy spec so a regular user is expected to be allowed :index?
  • Updated the people authorization request spec to expect a 200 (instead of redirect to root) for a regular user hitting /people

UI Testing Checklist

  • Sign in as a regular user, visit /people, confirm the index loads (200)
  • Confirm regular users still cannot view individual person show/edit/update pages unless they own them
  • Confirm admins still see all people on the index
  • Confirm people typeahead (/search?model=person&q=...) returns results for a regular user

Anything else to add?

Open up the People index and people typeahead search to all
authenticated users (previously admin-only). Show, edit, update,
destroy remain admin-only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@maebeale maebeale force-pushed the maebeale/people-index-authenticated branch from 42ab70f to 9dbb9c9 Compare May 15, 2026 14:16
@maebeale maebeale changed the title Allow authenticated users to access the people index and search HOLD UNTIL READY TO LAUNCH: Allow authenticated users to access the people index and search May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant