[WIP] Fix Add Language error on empty language #4056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
erb
ruby
compwron
changed the title
Collaborator
Author
|
Current behavior: When using the 'Add language' drop-down on the 'Edit User's Profile' page logged in as a Volunteer:
|
Collaborator
|
How's this going? It looks promising! :) |
Collaborator
Author
|
Hi! Good!
The functionality for the issue is currently working as expected. Because
we also moved a method from the languages_controller to the
users_controller we are having to write/rewrite/modify a lot of tests.
There is a counterpart method that will need to be moved as well to match.
(add_language, remove_language). We added a new issue for this. #4079.
So, although the behavior is correct when testing manually, the testing is
not complete.
: )
…On Mon, Oct 17, 2022 at 6:36 PM compwron ***@***.***> wrote:
How's this going? It looks promising! :)
—
Reply to this email directly, view it on GitHub
<#4056 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR3VCDIUOZFIIRYZE544OITWDX5IPANCNFSM6AAAAAARC2LXFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…er and modified route and form submit and add user policy test
…method name in users controller
…n language policy and language policy spec, add add_language method to users_spec.rb
…_spec as the add_language method is no longer in the languages_controller
elhalvers
force-pushed
the
3960-add_language_error
branch
from
8a947a0 to
7fe5306
Compare
Collaborator
Author
|
All the checks pass. I need to finish the stubbed tests 🙂 |
Collaborator
|
:) |
compwron
approved these changes
Oct 31, 2022
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #3960
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9