[WIP] Organization SMS Twilio Feature Updates Roadmap#4836
Closed
ShamiTomita wants to merge 76 commits into
Closed
[WIP] Organization SMS Twilio Feature Updates Roadmap#4836ShamiTomita wants to merge 76 commits into
ShamiTomita wants to merge 76 commits into
Conversation
github-actions
Bot
added
erb
littleforest
changed the title
author SHAMI_TOMITA <shamitomita@gmail.com> 1685494336 -0400 committer SHAMI_TOMITA <shamitomita@gmail.com> 1685574651 -0400 added back the return value lint and app controller spec TwilioService resource to current_user remove unecessary code, refactor lint removing unnecessary complexity rename for sms_reactivation js file password spec lint twilio service spec move lint remove comment remove comment revert to old gem file actual revert lint Update Gemfile.lock revert to old gem file actual revert lint Update Gemfile.lock
…/github.com/ShamiTomita/casa into st/4815/AddSMStoOrganizationFeaturesSection
I'm so sorry
Last and final commit
Collaborator
Author
|
I'm sorry for all of the commits, I was trying to squash all the small ones but ended up adding more >.< . I think all of the files are fine now though. |
Great job getting all of this together @ShamiTomita! |
ShamiTomita
changed the title
…/github.com/ShamiTomita/casa into st/4815/AddSMStoOrganizationFeaturesSection
ShamiTomita
changed the title
ShamiTomita
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #4815
What changed, and why?
Changes to Twilio Functionality in frontend and backend.
On Edit Casa Organization, the Twilio Form Inputs have been nested in an accordion drop down within the Organization Features section. Currently, if the Twilio Enabled checkbox is checked (and if the rest of the form has valid inputs), the CASA org will validate its Twilio Credentials upon update. If the Twilio checkbox is disabled, any existing Twilio credentials are still stored but any SMS services should return a notice saying: "SMS notice was not sent. Error: Twilio Is Not Enabled."
The TwilioService now has its own custom error that handles checking to see if a casa_org has twilio enabled.
Changes include:
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Relevant tests added for all three user types, application controller, requests/users/password_spec.rb
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9