Fix flaky contact type alphabetization test #5179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aedwardg
requested review from
FireLemons,
compwron and
littleforest
as code owners
aedwardg
force-pushed
the
5176-fix-flaky-contact-type-test
branch
from
1aa024a to
03ead8c
Compare
aedwardg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5176
What changed, and why?
Previous test was relying on factory sequences, but alphabetization of numerical strings can have unexpected results.
For example:
This PR updates the test to use hard-coded names for the case contacts so that alphabetization will always return the same result.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
The change is a test 🙂
Screenshots please :)
Feelings gif (optional)
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9