BUG: no validation for email in new fund request form#6284
Merged
compwron merged 1 commit intorubyforgood:mainfrom Mar 31, 2025
Merged
BUG: no validation for email in new fund request form#6284compwron merged 1 commit intorubyforgood:mainfrom
compwron merged 1 commit intorubyforgood:mainfrom
Conversation
piyush-pawar828
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
ruby
Contributor
Author
|
@compwron @FireLemons @elasticspoon could you guys please help me to review the PR? Thanks! |
compwron
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6281
What changed, and why?
Added validation for email because previously user can submit the fund request with any input.
Before:
After:
How is this tested? (please write rspec and jest tests!) 💖💪
I've added test cases for the same.
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
