Skip to content

fix race condition in casa_admins/edit_spec.rb #6352

Merged
FireLemons merged 1 commit intorubyforgood:mainfrom
alancovarrubias:6336_test_overhaul
Apr 10, 2025
Merged

fix race condition in casa_admins/edit_spec.rb #6352
FireLemons merged 1 commit intorubyforgood:mainfrom
alancovarrubias:6336_test_overhaul

Conversation

@alancovarrubias
Copy link

@alancovarrubias alancovarrubias commented Apr 9, 2025

What github issue is this PR for, if any?

Resolves #6336

What changed, and why?

Tests to fix race condition that occurs when running tests in a low resource environment.

How is this tested? (please write rspec and jest tests!) 💖💪

This was not tested in a low resource environment but the tests pass in my local environment.

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Apr 9, 2025
@alancovarrubias alancovarrubias marked this pull request as ready for review April 9, 2025 06:10
@FireLemons FireLemons changed the title update casa_admins/edit_spec.rb to account for race condition fix race condition in casa_admins/edit_spec.rb Apr 10, 2025
@FireLemons FireLemons merged commit 4274abb into rubyforgood:main Apr 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System Test Overhaul spec/system/casa_admins/edit_spec.rb

2 participants