Merged
Conversation
…ng extensions - rubocop-capybara - rubocop-rspec - rubocop-rspec_rails
Collaborator
|
Good draft! Make sure that the lint part of CI passes. |
Following spec files were updated - spec/system/static/index_spec.rb - spec/system/volunteers/index_spec.rb - spec/views/all_casa_admins/patch_notes/index.html.erb_spec.rb
Contributor
Author
Gotcha! All checks passing now 👍🏽 Looks like main was recently updated so I can rebase/merge when approved. Thank you! |
compwron
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6380
What changed, and why?
Update rubocop config file to specify "plugins" instead of "require" for the following extensions:
This ensures all extensions are supported properly.
How is this tested? (please write rspec and jest tests!) 💖💪
Manual testing
run
bundle exec standardrbWe now receive the following output -
Before we received