Skip to content

Rubocop config tune up#6398

Merged
compwron merged 2 commits intorubyforgood:mainfrom
Gabe-Torres:6380-rubocop-config-tune
May 22, 2025
Merged

Rubocop config tune up#6398
compwron merged 2 commits intorubyforgood:mainfrom
Gabe-Torres:6380-rubocop-config-tune

Conversation

@Gabe-Torres
Copy link
Copy Markdown
Contributor

@Gabe-Torres Gabe-Torres commented May 21, 2025

What github issue is this PR for, if any?

Resolves #6380

What changed, and why?

Update rubocop config file to specify "plugins" instead of "require" for the following extensions:

  • rubocop-capybara
  • rubocop-rspec
  • rubocop-rspec_rails

This ensures all extensions are supported properly.

How is this tested? (please write rspec and jest tests!) 💖💪

Manual testing
run bundle exec standardrb

We now receive the following output -

Warning: Lint/UselessAccessModifier does not support ContextCreatingMethods parameter.

Supported parameters are:

  - Enabled

Before we received

Warning: Lint/UselessAccessModifier does not support ContextCreatingMethods parameter.

Supported parameters are:

- Enabled
rubocop-capybara extension supports plugin, specify `plugins: rubocop-capybara` instead of `require: rubocop-capybara` in /home/runner/work/casa/casa/.rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.
rubocop-rspec extension supports plugin, specify `plugins: rubocop-rspec` instead of `require: rubocop-rspec` in /home/runner/work/casa/casa/.rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.
rubocop-rspec_rails extension supports plugin, specify `plugins: rubocop-rspec_rails` instead of `require: rubocop-rspec_rails` in /home/runner/work/casa/casa/.rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.
WARNING: this project is being migrated to standard gradually via `/home/runner/work/casa/casa/.standard_todo.yml` and is ignoring these files:
app/controllers/all_casa_admins/sessions_controller.rb
app/controllers/api/v1/base_controller.rb

CGT

…ng extensions

- rubocop-capybara
- rubocop-rspec
- rubocop-rspec_rails
@Gabe-Torres Gabe-Torres marked this pull request as draft May 21, 2025 02:44
@compwron
Copy link
Copy Markdown
Collaborator

Good draft! Make sure that the lint part of CI passes.
(the docker part of CI is temporarily broken in general and not related to this PR)

Following spec files were updated

- spec/system/static/index_spec.rb
- spec/system/volunteers/index_spec.rb
- spec/views/all_casa_admins/patch_notes/index.html.erb_spec.rb
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 21, 2025
@Gabe-Torres Gabe-Torres marked this pull request as ready for review May 21, 2025 22:59
@Gabe-Torres
Copy link
Copy Markdown
Contributor Author

Good draft! Make sure that the lint part of CI passes. (the docker part of CI is temporarily broken in general and not related to this PR)

Gotcha! All checks passing now 👍🏽 Looks like main was recently updated so I can rebase/merge when approved. Thank you!

@compwron compwron merged commit ba2baa8 into rubyforgood:main May 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tune rubocop config

2 participants