Add spec for trim_name method in CustomOrgLink model #6407
Merged
compwron merged 1 commit intorubyforgood:mainfrom Jun 5, 2025
Merged
Add spec for trim_name method in CustomOrgLink model #6407compwron merged 1 commit intorubyforgood:mainfrom
compwron merged 1 commit intorubyforgood:mainfrom
Conversation
nizam12khan
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
nizam12khan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #6404
Changes:
trim_namemethod inCustomOrgLinkmodel, which was implemented in Fix #6404: Trim whitespace from custom link text before saving #6405trim_nametrims whitespace from thetextattribute when presentsaveto trigger thebefore_savecallback.Testing:
rspec spec/models/custom_org_link_spec.rband confirmed the tests pass.