Upgrade node to v24 #6708
Merged
Upgrade node to v24 #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
The image couldn't be built without explicitely downloading this node's version. Maybe on Ruby's 3.3.10 alpine, it will be available and we don't need these lines.
stefannibrasil
force-pushed
the
sb-upgrade-node-to-v24
branch
from
a038ae6 to
de19c11
Compare
stefannibrasil
commented
Feb 11, 2026
| # Install NVM and Node JS | ||
| # you can use curl | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash |
Contributor
Author
There was a problem hiding this comment.
Extracted from https://github.com/nvm-sh/nvm?tab=readme-ov-file#install--update-script
I do not use Linux, so I couldn't verify this works, though.
This seems to be a bug from npm. Removing them from this PR to isolate the node upgrade changes only.
stefannibrasil
requested review from
FireLemons,
compwron,
elasticspoon and
schoork
as code owners
Collaborator
|
🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #6688
What changed, and why?
My local env generated some
peer: truechanges in thepackage.jsonfile. However, this seems to be a bug related to npm. I removed them from this PR to isolate the node changes.How is this tested?
Tests are passing! I also built js and css, and checked the app locally and didn't find any errors, and no console's errors either:
casa.node.24.mov
I am also happy to QA this branch in the QA env, if needed.