Remove ActionMailer call in casa_cases spec#6765
Open
jyeharry wants to merge 1 commit intorubyforgood:mainfrom
Open
Remove ActionMailer call in casa_cases spec#6765jyeharry wants to merge 1 commit intorubyforgood:mainfrom
jyeharry wants to merge 1 commit intorubyforgood:mainfrom
Conversation
jyeharry
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6703
What changed, and why?
The only
casa_casespec files which contained calls toActionMailerwasspec/system/casa_cases/show_more_spec.rb. The assertion that usedActionMailerwas right after an assertion that checks the presence of the"Reminder sent to volunteer"notice, so the test is already asserting that mail was sent successfully. I added an assertion that the page is on theedit_volunteer_pathpage just for clarity of the expected behaviour in the test but this may be unnecessary.How is this tested? (please write rspec and jest tests!) 💖💪
Updated
spec/system/casa_cases/show_more_spec.rb.