Placements controller coverage#6817
Open
stefannibrasil wants to merge 2 commits intorubyforgood:mainfrom
Open
Conversation
This action is not defined anywhere in the controller level. Removing it to keep things tidy and clean up a standardrb todo item.
stefannibrasil
force-pushed
the
sb-placements-controller-coverage
branch
from
1d48808 to
e21f187
Compare
The PlacementsController is a full CRUD for Youth placement records but only has a pending controller placeholder spec. This commit adds coverage for it.
stefannibrasil
force-pushed
the
sb-placements-controller-coverage
branch
from
e21f187 to
6eae19c
Compare
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #6816
What changed, and why?
generateaction fromPlacementsController. This action is not defined anywhere at the controller level. Removing it to keep things tidy and clean up a standardrb todo item.There are system tests for Placements: https://github.com/rubyforgood/casa/tree/main/spec/system/placements but the request specs are good unit tests to have anyway.