Fix Twilio phone number form validation test#6863
Merged
compwron merged 2 commits intorubyforgood:mainfrom Apr 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
No Issue. Change too small to require one, right? Last of the failing tests on
mainin my local environment...What changed, and why?
Brittle browser form validation message assertion replaced with testing browser form validity state (
:invalid). This to avoid locale-dependent test failures due to "Fill in" (UK English) and "Fill out" (USA English) inconsistency.How is this tested? (please write rspec and jest tests!) 💖💪
NB UK locale.
Before:
After:
Passes with
""as a phone number.Fails with
"01234567":Screenshots please :)
Feelings gif (optional)