Skip to content

Another three DRY spec refactors (case_contacts_helper_spec.rb, resolve_spec.rb, header.html.erb_spec.rb)#6899

Open
alanparmenter wants to merge 4 commits intorubyforgood:mainfrom
alanparmenter:refactor2
Open

Another three DRY spec refactors (case_contacts_helper_spec.rb, resolve_spec.rb, header.html.erb_spec.rb)#6899
alanparmenter wants to merge 4 commits intorubyforgood:mainfrom
alanparmenter:refactor2

Conversation

@alanparmenter
Copy link
Copy Markdown
Contributor

What github issue is this PR for, if any?

Relates to #6874

What changed, and why?

shared_examples added because these specs (case_contacts_helper_spec.rb, resolve_spec.rb, header.html.erb_spec.rb) have repeated examples.

How is this tested? (please write rspec and jest tests!) 💖💪

bundle exec rspec spec/helpers/case_contacts_helper_spec.rb
bundle exec rspec spec/system/case_contacts/followups/resolve_spec.rb
bundle exec rspec spec/views/layouts/header.html.erb_spec.rb

Feelings gif (optional)

Cactus using umbrella to stay dry

@github-actions github-actions Bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant