Unify remaining presenters into decorators#6970
Merged
compwron merged 1 commit intoMay 29, 2026
Merged
Conversation
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
Bot
added
🧪 Tests
stefannibrasil
force-pushed
the
unify-presenters-with-decorators
branch
2 times, most recently
from
e44df43 to
95cc830
Compare
The codebase has two parallel abstractions for view-layer logic: 1- 15 Draper decorators in app/decorators/ — the dominant pattern. 2- 2 presenters in app/presenters/ (BasePresenter, CaseContactPresenter). Maintaining two abstractions for the same job creates choice paralysis for new contributors and a small amount of cognitive overhead reading the codebase. This commit move the remaining presenter logic into a collection decorator and unifies decorating/presenting into app/decorators to reduce cognitive overhead when maintaining the codebase. More unifying work better names
stefannibrasil
force-pushed
the
unify-presenters-with-decorators
branch
from
95cc830 to
b3ea568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #6909
What changed, and why?
The codebase has two parallel abstractions for view-layer logic:
1- 15 Draper decorators in
app/decorators/— the dominant pattern.2- 2 presenters in
app/presenters/(BasePresenter,CaseContactPresenter).Maintaining two abstractions for the same job creates choice paralysis for new contributors and a small amount of cognitive overhead reading the codebase.
This PR moves the remaining presenter logic into a collection decorator and unifies decorating/presenting into app/decorators to reduce cognitive overhead
when maintaining the codebase.
How is this tested? (please write rspec and jest tests!) 💖💪
Short video of the page after the changes:
https://github.com/user-attachments/assets/27f58792-f5d0-456e-9877-4647a12b97f6