Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 27 additions & 36 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,39 +92,30 @@ jobs:
# RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
# REDIS_URL: redis://localhost:6379/0
run: bin/rails db:test:prepare test
# TODO: Re-enable this once a system test exists. Currently this fails because the system test files haven't been generated yet.
# system-test:
# runs-on: ubuntu-latest
#
# # services:
# # redis:
# # image: valkey/valkey:8
# # ports:
# # - 6379:6379
# # options: --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
# steps:
# - name: Install packages
# run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libvips
#
# - name: Checkout code
# uses: actions/checkout@v6
#
# - name: Set up Ruby
# uses: ruby/setup-ruby@v1
# with:
# bundler-cache: true
#
# - name: Run System Tests
# env:
# RAILS_ENV: test
# # RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
# # REDIS_URL: redis://localhost:6379/0
# run: bin/rails db:test:prepare test:system
#
# - name: Keep screenshots from failed system tests
# uses: actions/upload-artifact@v7
# if: failure()
# with:
# name: screenshots
# path: ${{ github.workspace }}/tmp/screenshots
# if-no-files-found: ignore
system-test:
runs-on: ubuntu-latest
steps:
- name: Install packages
run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libvips

- name: Checkout code
uses: actions/checkout@v6

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true

- name: Run System Tests
env:
RAILS_ENV: test
# RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
run: bin/rails db:test:prepare test:system

- name: Keep screenshots from failed system tests
uses: actions/upload-artifact@v7
if: failure()
with:
name: screenshots
path: ${{ github.workspace }}/tmp/screenshots
if-no-files-found: ignore
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -595,4 +595,4 @@ CHECKSUMS
zeitwerk (2.8.2) sha256=7212a61311083c604184b1ea2574b9aa05cd14f855a0841c06985cabe9181d12

BUNDLED WITH
4.0.3
4.0.12
2 changes: 1 addition & 1 deletion test/system/student_accessibility_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class StudentAccessibilityTest < ApplicationSystemTestCase
click_on student.full_name

# Verify we are on the student home page
assert_selector "h1", text: "Welcome to EndsideOut"
assert_selector "h1", text: "Welcome, #{student.first_name}!"

# Check accessibility of the home page
assert_accessible
Expand Down