Remove recent from diaper driver calculation#1031
Merged
seanmarcia merged 1 commit intorubyforgood:masterfrom Jun 1, 2019
JuarezLustosa:fix/month_dash_distribution
Merged
Remove recent from diaper driver calculation#1031seanmarcia merged 1 commit intorubyforgood:masterfrom JuarezLustosa:fix/month_dash_distribution
seanmarcia merged 1 commit intorubyforgood:masterfrom
JuarezLustosa:fix/month_dash_distribution
Conversation
Member
|
Thanks for this! |
Collaborator
|
@JuarezLustosa Hey! Thanks for writing this :) I've actually got a PR (#1030) that resolves this issue as well in addition to fixing our Dashboard system specs, but I would like to see if we can still get you some commit credit for taking this on. Could you open a new PR that puts your branch Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1029
Description
The Diaper drive calculation was coming from recent_donations, so was getting only 3.
Type of change
How Has This Been Tested?
Acceptance Test plus manual