#4644 disable buttons after clicking confirm on distribution/request#4667
Merged
Conversation
jimmyli97
force-pushed
the
4644-disable-doubleclick
branch
from
3dfb1cc to
d4712b2
Compare
jimmyli97
changed the title
Collaborator
|
@jimmyli97 FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this. Hopefully this week will go better. |
Collaborator
|
All good on my end! @cielf did you want to take a look? |
Collaborator
|
Will do. Probably tomorrow, maybe Tuesday. |
Contributor
|
@jimmyli97: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4644
Description
note that I was unable to reproduce any issues as a result of double clicking or clicking on multiple buttons after clicking on "Yes it's correct", so the rspecs check for disabled buttons only
Type of change
How Has This Been Tested?
passes test suite
manual testing by disabling form submission (set form action to
javascript: void(0);) and modal hiding (comment out the hide modal line inassets/controllers/confirmation_controller.js#submitForm()) in dev toolsScreenshots
New color (same color as "Submit Essentials Request"):
Disabled buttons:
