Skip to content

Change State to Status on Distribution Table#4670

Merged
cielf merged 3 commits into
rubyforgood:mainfrom
lit-poks:fix/distribution-enum-state-to-status
Oct 6, 2024
Merged

Change State to Status on Distribution Table#4670
cielf merged 3 commits into
rubyforgood:mainfrom
lit-poks:fix/distribution-enum-state-to-status

Conversation

@lit-poks
Copy link
Copy Markdown
Contributor

@lit-poks lit-poks commented Sep 29, 2024 •
edited
Loading

Resolves #4603

Description

  • Changes the state column to status
  • Enums have been changed
  • Test example descriptions have been changed
  • Changes on export made

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Has been tested locally with all unit tests passing
  • Has been verified on the FE that it shows Status
  • Has been verified by downloading distributions csv that it shows as status on csv as well

State Renaming on FE test steps:

  • Login as Bank User with email: user_1@example.com
  • Navigate to Distributions
  • Check Column is being shown as status

State Renaming on CSV download test steps:

  • Login as Bank User with email: user_1@example.com
  • Navigate to Distributions
  • Export Distributions
  • Verify that the CSV shows the column Status

Screenshots

  • Screenshots for verification:
image image

@lit-poks lit-poks changed the title [WIP] Change State to Status on Distribution Table Change State to Status on Distribution Table Sep 29, 2024
@lit-poks lit-poks marked this pull request as ready for review September 29, 2024 10:32
@lit-poks lit-poks mentioned this pull request Sep 29, 2024
Closed
3 tasks
dorner
dorner previously requested changes Sep 30, 2024
View reviewed changes
Comment thread db/migrate/20240929074158_rename_state_to_status.rb Outdated
@lit-poks lit-poks force-pushed the fix/distribution-enum-state-to-status branch from 1650cf2 to d07bbab Compare October 4, 2024 09:36
@lit-poks
Copy link
Copy Markdown
Contributor Author

lit-poks commented Oct 4, 2024

@dorner, changes made only to views. Please review

@lit-poks lit-poks requested review from cielf and dorner October 4, 2024 09:38
cielf
cielf approved these changes Oct 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf dismissed dorner’s stale review October 6, 2024 14:55

It's been addressed

@cielf cielf merged commit 2b6ee74 into rubyforgood:main Oct 6, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 13, 2024

@lit-poks: Your PR Change State to Status on Distribution Table is part of today's Human Essentials production release: 2024.10.13.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cielf cielf cielf approved these changes

@dorner dorner Awaiting requested review from dorner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On distribution, state should be status

3 participants

@lit-poks @dorner @cielf