Renames diaper acquisition to diapers#4702
Merged
cielf merged 4 commits intoOct 14, 2024
Merged
Conversation
Collaborator
Author
|
for your review @cielf |
cielf
requested changes
Oct 4, 2024
Collaborator
cielf
left a comment
cielf
left a comment
There was a problem hiding this comment.
Looks great functionally - I've got one remark on the test.
| year = 1.year.ago.year | ||
| click_on(year.to_s) | ||
| expect(page).to have_content("Diaper Acquisition") | ||
| expect(page).to have_content("Diapers") |
Collaborator
There was a problem hiding this comment.
This test would have passed while the heading was still "Diaper Acquisition". because there are other cases of "Diapers" in the report. I suppose we can check that it's h1 as well.
- rename service class - update test specs - update report name
sbpipb
force-pushed
the
4686_rename_report_diaper_acquisition_to_diaper
branch
from
fa118b4 to
1d02634
Compare
Contributor
|
@sbpipb: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4686
Description
Type of change