Resolves #4677 - Require Business Name for Vendors

[cassieemb]

Resolves #4677

Description

This PR makes business_name mandatory when creating or updating a Vendor through the Community | Vendors form and the Purchases | New Vendor form. Previously the validations ensured that at least a contact_name or business_name was entered, but the dropdown to select a vendor looks a little funky without a business_name.

This change prevents further vendors from being created with empty business names, but we still need to handle the existing cases of this. Since we know that either a business_name or contact_name was required, we run a migration to backfill the business_name from the contact_name for any vendor instance that is missing one.

I added the validation on business_name to the Vendor model and while that alone works correctly with specs, it didn't look the nicest displayed on the form submission because:

a) it shows the error on contact_name which doesn't make as much sense now that business_name is always required
b) it shows the error on business_name from the provideable validation in addition to the error on business_name from the vendor validation

I originally wanted to avoid modifying Provideable, but it felt like the logic to handle exclusively from Vendor was messier than it would be to just add a check in provideable to skip those validations when the model is vendor so that we can use the vendor specific validations instead.

Type of change

I wasn't 100% sure which of these to choose - I don't think I'd call this a breaking change, but existing functionality would be expected to accept an empty business name when contact is supplied, so this change is different than expectations.

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

• Ran Lint locally
• Ran the RSpec test suite locally (I had two unrelated system tests failing, but they were failing on main too, so checking to see if they pass with CI to confirm it's a local issue)
• Tested on Vendor create/update through Community | Vendors
• Tested on Vendor create through Purchases | New Purchase
• I created a number of vendors with blank business names on main, and then swapped to my branch and ran the migration to see the business names backfilled from the contact name

Screenshots

[dorner]

Perfect, thanks!

[github-actions]

@cassieemb: Your PR Resolves #4677 - Require Business Name for Vendors is part of today's Human Essentials production release: 2024.10.13.
Thank you very much for your contribution!