Discarded Storage Location and Inactive Item

[lit-poks]

Resolves #4526

Description

• Added a Storage Location that is discarded in the seed
• Made atleast one item of an organization inactive

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing Inactive Item:

• Login as org_admin1@example.com
• Go to Inventory > Items and Inventory
• Go to Items Tab
• Filter for Item that was marked inactive (in my case Adult Briefs (Large/X-Large))
• Check if it appears on the list (it doesnt) (first screenshot)
• Click the Also include inactive items checkbox
• Check if it appears on the list(second screenshot), it does!

Testing Discarded Storage Location

• Login as org_admin1@example.com
• Go to Inventory > storage locations
• At first only 2 storage location appears (third screenshot)
• Click the include inactive storage locations checkbox
• Check if it appears on the list(fourth screenshot), it does!

Screenshots

[cielf]

Hey @lit-poks, you've got an item with an inactive status and a storage location that has an inactive status -- good -- but you missed that they both have to have 0 current inventory. Can you address that, please?

[lit-poks]

hi @cielf , i made the changes regarding inventory they are 0 for both now. I hope it is what you are looking for.

let me know if there are any issues. cheers

[cielf]

The item looks alright. I'm still seeing inventory for the inactive storage location, though.

I think what's going on is that various things that add items in the seed (such as donations, purchases, adjustments, transfers) might not be limiting themselves to active storage locations.

[lit-poks]

Hi @cielf,

found the leak, it was from Donations. should be all fixed now. please check. tested it on my end as well.

[github-actions]

@lit-poks: Your PR Discarded Storage Location and Inactive Item is part of today's Human Essentials production release: 2024.10.20.
Thank you very much for your contribution!