Skip to content

[#4789] add step-wise editing for banks view of partner profile#4799

Merged
dorner merged 1 commit intorubyforgood:mainfrom
danielabar:4789-bank-partner-profile-step-form
Nov 27, 2024
Merged

[#4789] add step-wise editing for banks view of partner profile#4799
dorner merged 1 commit intorubyforgood:mainfrom
danielabar:4789-bank-partner-profile-step-form

Conversation

@danielabar
Copy link
Copy Markdown
Collaborator

Resolves #4789

Description

Similar to the 4504 work, this modifies the bank's view of editing a partner profile to also be a step-wise, using Bootstrap Accordion. Fortunately all the same partials that were introduced for partner profile can be re-used here.

Type of change

New feature/follow-on.

How Has This Been Tested?

Automated tests added at spec/system/partner_system_spec.rb, see describe "#edit_profile" do.

For manual testing:

Start by enabling the feature flag in a Rails console bin/rails c:

Flipper.enable(:partner_step_form)
  1. Login as org admin
  2. From left nav, select Partner Agencies -> All Partners
  3. Click on any Partner name
  4. From the Partner Profile information (you might need to scroll down a bit to get to this section), click on "Edit Information"
  5. You should be on the partner profile edit view with all sections in a closed accordion state (see screenshots section)
  6. Functionality is the same as what was done in 4504 (including error handling). Except clicking Save and Review will navigate to the banks Partner Profile view at for example: http://localhost:3000/partners/8#partner-information

Screenshots

image

@danielabar danielabar requested a review from cielf November 24, 2024 11:52
Copy link
Copy Markdown
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- passing to @dorner for the technical bits.

@cielf cielf requested a review from dorner November 25, 2024 14:18
Copy link
Copy Markdown
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here too! 🎉

@dorner dorner merged commit 37f41ee into rubyforgood:main Nov 27, 2024
Sukhpreet-s pushed a commit to Sukhpreet-s/human-essentials that referenced this pull request Nov 29, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2024

@danielabar: Your PR [#4789] add step-wise editing for banks view of partner profile is part of today's Human Essentials production release: 2024.12.01.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework the bank's experience of the Partner Profile to match the partners'

3 participants