Fix time zone flakiness in distribution by county specs#4825
Merged
dorner merged 1 commit intorubyforgood:mainfrom Dec 10, 2024
coalest:fix-flaky-prior-year-date-picker-spec
Merged
Fix time zone flakiness in distribution by county specs#4825dorner merged 1 commit intorubyforgood:mainfrom coalest:fix-flaky-prior-year-date-picker-spec
dorner merged 1 commit intorubyforgood:mainfrom
coalest:fix-flaky-prior-year-date-picker-spec
Conversation
Contributor
|
@coalest: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apparently some of the specs I added were flaky in two different ways 🙃
Example of it failing in CI
Error message:
Pretty sure this is a time zone issue. We query times in Los Angeles time zone during tests. But we were saving times in UTC to the database.
Type of change
How Has This Been Tested?
Locally