Show all active partners on distributions page unrestricted by filter#4836
Merged
dorner merged 3 commits intorubyforgood:mainfrom Dec 10, 2024
coalest:4834-distribution-filter-on-partner-is-currently-restricted-on-date-range-and-should-not-be
Merged
Show all active partners on distributions page unrestricted by filter#4836dorner merged 3 commits intorubyforgood:mainfrom coalest:4834-distribution-filter-on-partner-is-currently-restricted-on-date-range-and-should-not-be
dorner merged 3 commits intorubyforgood:mainfrom
coalest:4834-distribution-filter-on-partner-is-currently-restricted-on-date-range-and-should-not-be
Conversation
…ilter-on-partner-is-currently-restricted-on-date-range-and-should-not-be
Collaborator
Author
|
Fixed the merge conflict, so this is ready for review again. |
Collaborator
|
LGTM functionality-wise. |
Contributor
|
@coalest: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4834
Description
See #4834 for the issue and reproduction steps.
Type of change
How Has This Been Tested?
Added a new request spec.
Screenshots
Before:
Filtering by date filter for day with no distributions => No partner dropdown box at all.
After:
No distributions after filtering but all active partners still selectable in dropdown.