Allow linting subset of files with bin/lint and fix erb_lint deprecation errors #4852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Dec 14, 2024
Contributor
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
Erb lint was giving some deprecation warning about the name of the file/command, so those were fixed.
Also added the ability to pass along individual files/folders to the bin/lint command, because linting all files takes 30 seconds on my laptop and I am often only changing a few files per branch. (If this change is unwanted, I can remove it and just use an alias on my computer. But I figured it might help others)
Type of change
How Has This Been Tested?
Only manually, as these are bash functions.
Screenshots
Note the old deprecation warnings:
