Deleting BarcodeItem works as intended #5022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jp524: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4989
Description
When trying to delete a BarcodeItem, there was also an attempt to delete the associated Item.
I removed the
dependent: :destroyoption on thebelongs_toassociation to fix this. Per Rails documentation for the:dependentoption, this option shouldn't be used anyway if there is a correspondinghas_manyassociation.I also ensured that flash messages are being displayed if the BarcodeItem is deleted or if it fails to delete.
Type of change
How Has This Been Tested?
Added some model tests for BarcodeItem. Modified existing admin system spec for BarcodeItem to be more precise on the expectation.
Screenshots
Screen.Recording.2025-02-16.at.11.13.13.mov