-
-
Notifications
You must be signed in to change notification settings - Fork 572
feat: add ability to add and show partner-specific information #5075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d388e78 to
810bba3
Compare
810bba3 to
89643a9
Compare
|
Note: Apparently this PR does not include the user guide fixes. Therefore downgrading the "Fixes" to "Partial" |
|
Heads up to @khiga8 It may take me a few days to get this tested. |
|
Hey @khiga8 -- thanks for this! It does what was asked for -- excluding the user guide changes -- I'm seeing that I should have also asked for it to be added in to the bank's view of the partner, between notes and partner profile. ps. this still has to go through a technical review, and heads up -- we won't be merging this without the user guide changes. |
dorner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - had one question.
|
|
||
| <main> | ||
| <% if @partner.info_for_partner %> | ||
| <%= render partial: 'info_for_partner', locals: { info_for_partner: @partner.info_for_partner} %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need its own partial? It's four lines of view code.
Partial: #5020
Description
info_for_partnerfield to thepartner.rbmodel.partners_controller.rbto accept new field params.Type of change
How Has This Been Tested?
I updated the
spec/system/partner_system_spec.rbspec.Screenshots