Skip to content

Conversation

@khiga8
Copy link
Contributor

@khiga8 khiga8 commented Mar 6, 2025

Partial: #5020

Description

  • Database migration to add new info_for_partner field to the partner.rb model.
  • Update the create/edit partner information frontend with a new textarea. (for partner)
  • Update the partners_controller.rb to accept new field params.
  • Update the dashboard page for partner to add information.
  • Added a test

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I updated the spec/system/partner_system_spec.rb spec.

Screenshots

New form field with the label 'Partner specific information (500 characters) Partner specific information is shown on the partner dashboard under the heading 'Info'

@khiga8 khiga8 force-pushed the kh-add-partner-specific-info branch from d388e78 to 810bba3 Compare March 11, 2025 22:26
@khiga8 khiga8 force-pushed the kh-add-partner-specific-info branch from 810bba3 to 89643a9 Compare April 9, 2025 02:00
@khiga8 khiga8 changed the title WIP: add ability to add and show partner-specific information feat: add ability to add and show partner-specific information Apr 9, 2025
@khiga8 khiga8 marked this pull request as ready for review April 9, 2025 02:47
@cielf
Copy link
Collaborator

cielf commented Apr 9, 2025

Note: Apparently this PR does not include the user guide fixes. Therefore downgrading the "Fixes" to "Partial"

@cielf
Copy link
Collaborator

cielf commented Apr 9, 2025

Heads up to @khiga8 It may take me a few days to get this tested.

@cielf
Copy link
Collaborator

cielf commented Apr 11, 2025

Hey @khiga8 -- thanks for this! It does what was asked for -- excluding the user guide changes -- I'm seeing that I should have also asked for it to be added in to the bank's view of the partner, between notes and partner profile.
Are you up for handling that, or shall I put it into a new issue?

ps. this still has to go through a technical review, and heads up -- we won't be merging this without the user guide changes.

@cielf cielf requested a review from dorner April 11, 2025 18:31
@cielf
Copy link
Collaborator

cielf commented Apr 14, 2025

@dorner -- when you've reviewed this, please toss it back to me, and I'll handle the user guide, since @khiga8 doesn't think they have enough context.

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - had one question.


<main>
<% if @partner.info_for_partner %>
<%= render partial: 'info_for_partner', locals: { info_for_partner: @partner.info_for_partner} %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need its own partial? It's four lines of view code.

@awwaiid awwaiid self-assigned this Jun 22, 2025
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 6, 2025

Thanks @khiga8 ! I needed to make some small changes, so I did that over at #5270 . I'm closing this, but your work will soon be merged!

@awwaiid awwaiid closed this Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants