Skip to content

Conversation

@coalest
Copy link
Collaborator

@coalest coalest commented Mar 12, 2025

Resolves #5052

Description

Fixes the partner file upload

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually and with a new system spec.

Screenshots

Screenshots of uploaded files being persisted:
image

image

@cielf
Copy link
Collaborator

cielf commented Mar 13, 2025

Hey @coalest -- I haven't tried this out yet, but looking at the screenshots, I suggest that we adjust the appearance of the buttons to match what's being done in #5090 for consistency.

@coalest
Copy link
Collaborator Author

coalest commented Mar 14, 2025

Updated the styling. New screenshots:
Screenshot from 2025-03-14 10-29-17
Screenshot from 2025-03-14 10-29-05

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in a separate PR maybe more of the dynamic stuff from #5090 could be pulled in, but this works as a good step.

@awwaiid awwaiid merged commit ab7d15a into rubyforgood:main Mar 15, 2025
11 checks passed
@cielf
Copy link
Collaborator

cielf commented Mar 16, 2025

(nods) I have thrown showing the file names into a proto-issue, so we won't lose it if it doesn't get done immediately.

@github-actions
Copy link
Contributor

@coalest: Your PR Fix partner file upload is part of today's Human Essentials production release: 2025.03.16.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Partner file upload (the one on the partner record)

3 participants