Fix cat REVISION file warning on app startup #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
approved these changes
Mar 20, 2025
Collaborator
awwaiid
left a comment
awwaiid
left a comment
There was a problem hiding this comment.
This works. I had wondered about putting DEVELOPMENT as the content of the file and commit it, but I think this is better (and no risk of cloud66 then getting mad at the file existing)
Collaborator
Author
|
btw CI/CD won't pass until this flaky test gets fixed #5108 |
Contributor
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Just a minor nit of a PR)
Description
Fixes the following error message that occurs on app startup in dev:
cat: ./REVISION: No such file or directoryThat file is created in prod by Cloud 66, but not in dev/test hence the warning/error message.
Type of change
How Has This Been Tested?
Manually. See screenshots
Screenshots
Before the change:
After the change (first without the REVISION file like in non-prod environments and then with the file):
