Skip to content

Remove plain text email for DistributionMailer.partner_mailer#5119

Merged
cielf merged 1 commit into
rubyforgood:mainfrom
Sukhpreet-s:5098-remove-plain-text-partner-mailer
Mar 24, 2025
Merged

Remove plain text email for DistributionMailer.partner_mailer#5119
cielf merged 1 commit into
rubyforgood:mainfrom
Sukhpreet-s:5098-remove-plain-text-partner-mailer

Conversation

@Sukhpreet-s
Copy link
Copy Markdown
Contributor

Resolves #5098

Description

As discussed in the issue, plain text version for emails that include rich text content are not needed, and should be removed since they are not rendering properly .

This PR removes the plain text version of DistributionMailer.partner_mailer email. So now for this mailer, only HTML email is sent.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually and also ran existing tests.

Steps to test:

  1. Sign in as a bank admin
  2. Turn on the following setting for a Partner:
    • Do you want this partner to receive emails for distributions and reminders from the system?
  3. Create a new distribution for the above Partner
  4. Only html email is sent. For dev env, check /tmp/letter_opener

Screenshots

N/A

@cielf cielf self-requested a review March 24, 2025 15:10
Copy link
Copy Markdown
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit 33ccf43 into rubyforgood:main Mar 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

@Sukhpreet-s: Your PR Remove plain text email for DistributionMailer.partner_mailer`` is part of today's Human Essentials production release: 2025.03.30.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Rendering rich text fields in plain text email includes HTML comments and tags

2 participants