Switch to in-memory item selection to speed up export #5478
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We did not technically need to require csv, but did so so that the unit test would run by itself. Shouldn't hurt anything. |
Co-authored-by: Scott Steele <scottlsteele@gmail.com>
scooter-dangle
approved these changes
Jan 18, 2026
Collaborator
scooter-dangle
left a comment
scooter-dangle
left a comment
There was a problem hiding this comment.
El jee tea em! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pre-load distribution items, but when applying a sub-filter we were accidentally re-querying the database a bunch. This changes it to an in-memory filter.