Disallow saving Purchase with a quantity of 0 (#5507)#5510
Open
cassxw wants to merge 1 commit intorubyforgood:mainfrom
Open
Disallow saving Purchase with a quantity of 0 (#5507)#5510cassxw wants to merge 1 commit intorubyforgood:mainfrom
cassxw wants to merge 1 commit intorubyforgood:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5507
Description
This bug fix prevents users from saving a Purchase with zero quantity line items. Previously, users could create Purchases with 0 or blank quantities, which should not be allowed.
The fix adds validation to the Purchase model that checks all line items have a quantity of at least 1, reusing the existing
line_items_quantity_is_at_least(1)method from theItemizableconcern - which was already used by Donation, Distribution, and Transfer models.Note: The error message uses existing wording ("Inventory {item}'s quantity needs to be at least 1") rather than the issue's suggested wording, to remain consistent with other models.
Type of change
How Has This Been Tested?
spec/models/purchase_spec.rbthat verifies a Purchase with a zero-quantity line item is invalid.Screenshots