Add a new filter to distributions (and CSV) for reporting category#5512
Merged
Add a new filter to distributions (and CSV) for reporting category#5512
Conversation
Also fix the summary total labels when filters are applied
dorner
approved these changes
Mar 13, 2026
| @total_items_paginated_distributions = @distribution_totals.slice(*paginated_ids).values.sum(&:quantity) | ||
| @selected_item_category = filter_params[:by_item_category_id].presence | ||
| @reporting_categories = Item.reporting_categories_for_select | ||
| @selected_reporting_category = filter_params[:by_reporting_category].presence |
Collaborator
There was a problem hiding this comment.
When do we give in and realize that we're trying to shove a million instance variables into the view instead of using a proper view object? 😁
| it "only shows distributions containing items with the given reporting category" do | ||
| get distributions_path, params: params | ||
|
|
||
| expect(assigns(:distributions)).to include(distribution_pads) |
Collaborator
There was a problem hiding this comment.
and ideally to stop testing assigns, which is basically us reaching into private controller code instead of testing outputs.
Contributor
|
@awwaiid: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward #5511
This adds a new filter to distributions for the reporting category, similar to the existing filters.
Also fix the summary total labels when filters are applied.
Manually tested and added specs!