Fix inconsistent item headers in donation and purchase CSV exports#5539
Open
AHarris03 wants to merge 1 commit intorubyforgood:mainfrom
Open
Fix inconsistent item headers in donation and purchase CSV exports#5539AHarris03 wants to merge 1 commit intorubyforgood:mainfrom
AHarris03 wants to merge 1 commit intorubyforgood:mainfrom
Conversation
dorner
requested changes
Apr 17, 2026
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Actual changes look fine but there's an accidental commit that needs to be reverted.
| database: diaper_dev | ||
| username: <%= ENV.fetch("PG_USERNAME", 'postgres') %> | ||
| password: <%= ENV.fetch("PG_PASSWORD", nil) %> | ||
| username: aleha |
Collaborator
There was a problem hiding this comment.
This file shouldn't have been checked in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5152
Description
Previously, donation and purchase exports only included item columns present in the filtered dataset.
This change updates both export services to derive item headers from organization-level items, ensuring consistent CSV structure regardless of filters.
Manually verified:
Type of change
How Has This Been Tested?
After logging in as a bank user, I exported both the full donations and purchases list, and then also exported with filters on both. Once I had the csv files, I combed through to make sure that all columns were accounted for and they were in their respective places.
Screenshots