Skip to content

Conversation

@seanmarcia
Copy link
Member

@seanmarcia seanmarcia commented Feb 1, 2019

This PR does three things:

  • It updates the ruby version from 2.5.3 to 2.6.1
  • It refactors our filterable concern to change the method name from filter to class_filter. This is because with the release of ruby 2.6.0 they created filter as an alias on select on enumerable. I'm not entirely sure I like the name class_filter but I couldn't think of anything better at the time.
  • Updates our capistrano deploy scripts to use ruby 2.6.1

@seanmarcia seanmarcia requested a review from armahillo February 1, 2019 22:00
@armahillo
Copy link
Collaborator

class_filter is fine for now.

I have a gem started for that feature that I want to work on anyways, so eventually it will be something else :)

@armahillo armahillo merged commit a83ae6a into master Feb 7, 2019
@armahillo armahillo deleted the ruby261 branch February 7, 2019 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants