Cleanup one-off development containers created via make #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before any one-off container made by these make tasks hangs around in
an exited state after command execution is terminated - notice
`development_app_run_e3b196b37f5d` in the example below:
```
[maximilian: development] cleanup-one-off-development-containers *^ →
$ make rspec
docker-compose run app bin/rspec
...snip...
[maximilian: development] cleanup-one-off-development-containers *^ →
$ docker-compose ps -a
Name Command State Ports
-------------------------------------------------------------------------------------------------------------
development_app_run_e3b196b37f5d bin/rspec Exit 0
development_db_1 docker-entrypoint.sh postgres Up 5432/tcp
development_email_1 mailcatcher --foreground - ... Up 1025/tcp, 0.0.0.0:1080->1080/tcp
```
After, one off containers delete themselves when the container
exits. Notice in the example below that the
`development_app_run_<container-id>` container is not present after execution:
```
[maximilian: development] cleanup-one-off-development-containers +^ →
$ make rspec
docker-compose run --rm app bin/rspec
...snip...
[maximilian: development] cleanup-one-off-development-containers +^ →
$ docker-compose ps -a
Name Command State Ports
-----------------------------------------------------------------------------------------------
development_db_1 docker-entrypoint.sh postgres Up 5432/tcp
development_email_1 mailcatcher --foreground - ... Up 1025/tcp, 0.0.0.0:1080->1080/tcp
```
Nice and tidy.
thestephenmarshall
approved these changes
Sep 21, 2020
solebared
approved these changes
Sep 21, 2020
Collaborator
solebared
left a comment
solebared
left a comment
There was a problem hiding this comment.
Sweet, thanks for catching that!
Collaborator
Author
|
Cheers, mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, any one-off container made by these make tasks hangs around in
an exited state after command execution is terminated - notice
development_app_run_e3b196b37f5din the example below:After, one off containers delete themselves when the container
exits. Notice in the example below that the
development_app_run_<container-id>container is not present after execution:Nice and tidy.