Skip to content

Conversation

@svileshina
Copy link
Collaborator

@svileshina svileshina commented Feb 4, 2021

Why

In an effort to make things more RESTful where it is simple to do so, this PR combines the show and respond views into show and then uses pundit to differentiate between the views. There are also quite a few places where I then either removed the "Respond" button if both existed, or left it as "Respond" but changed the path.

Outstanding issues/things I could use some help with:

  • The contributions policy should be more specific I think - all people have permission to view the "show" but it is just what it displays that is being determined by pundit
  • requests/contributions_spec has two failing tests possibly because:
  • ListBrowser.vue had a showRespondColumn and a "contribution.respond_path" that I need to change to use show

Pre-Merge Checklist

  • All new features have been described in the pull request
  • Security & accessibility have been considered
  • High quality tests have been added, or an explanation has been given why the features cannot be tested
  • New features have been documented, and the code is understandable and well commented
  • Entry added to CHANGELOG.md if appropriate
  • All outstanding questions and concerns have been resolved
  • Any next steps that seem like good ideas have been created as issues for future discussion & implementation

What

Initial Respond Page
Screen Shot 2021-02-04 at 3 49 51 PM

Both are now the show but it depends on whether you are logged in or not, and if you are an admin or not
Screen Shot 2021-02-04 at 3 37 09 PM
Screen Shot 2021-02-04 at 3 45 54 PM

How

Testing

Next Steps

This is part of #840 (Re-enabling registration)

Outstanding Questions, Concerns and Other Notes

Accessibility

Security

Meta

@svileshina svileshina force-pushed the reworking-contributions-show-respond branch from fde664f to 46d8b64 Compare February 4, 2021 20:49
@solebared solebared mentioned this pull request Feb 4, 2021
30 tasks
Copy link
Collaborator

@solebared solebared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it first pass and it looks great! 👏🏾 .

I didn't dig into implementations of the extracted partials, assuming they were mostly copied over.

Couple comments inline.

@svileshina svileshina marked this pull request as ready for review February 14, 2021 16:25
@svileshina svileshina force-pushed the reworking-contributions-show-respond branch from 4c1c592 to a04a873 Compare February 14, 2021 16:50
Copy link
Collaborator

@solebared solebared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!! 🙌🏾

@svileshina svileshina force-pushed the reworking-contributions-show-respond branch from cf24ca2 to 25a762b Compare February 14, 2021 17:08
@svileshina svileshina merged commit ea1c4c7 into main Feb 14, 2021
@svileshina svileshina deleted the reworking-contributions-show-respond branch February 14, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants