Skip to content

Conversation

@h-m-m
Copy link
Collaborator

@h-m-m h-m-m commented Mar 20, 2021

Why

I think our team usage of peer-to-peer is potentionally confusing to community members new to this application. That phrase means different things in different contexts, so I'd like to reduce potential confusion.

Pre-Merge Checklist

  • All new features have been described in the pull request
  • Security & accessibility have been considered
  • High quality tests have been added, or an explanation has been given why the features cannot be tested
  • New features have been documented, and the code is understandable and well commented
  • Entry added to CHANGELOG.md if appropriate
  • All outstanding questions and concerns have been resolved
  • Any next steps that seem like good ideas have been created as issues for future discussion & implementation

What

I'm open to further changes to this if you'd like to improve the wording

Testing

Mobile breakboint:

Screen Shot 2021-02-23 at 10 01 51 AM

Wider breakpoint:

Screen Shot 2021-02-23 at 10 01 38 AM

Next Steps

n/a

Accessibility

This will hopefully improve legibility of this warning message

Security

This is a wording change that should have no security impact

I suppose we're now leaking a small amount of info about who has or has not entered their contact info. That is certainly a hard think to leverage in isolation, though

This needs further reworking, but the change here should be an improvement over the existing
@h-m-m h-m-m mentioned this pull request Mar 20, 2021
7 tasks
@solebared solebared merged commit ff780ea into main Mar 31, 2021
@solebared solebared deleted the contriubtions-p2p-claim-wording branch March 31, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants