Ensure only one current_organization and rename to instance_owner
#926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Discovered that every organization currently created is defaulted to
is_instance_owner: true.IIUC, only one org should be the instance owner.
Also renames
current_organizationbecause that name connotes something transient, egcurrent_user.What
organizations.is_instance_ownerdefault to falseOrganization.current_user->.instance_ownerOrganization.instance_ownerfrom a scope to a class method since it doesn't return a relationTesting
Next steps
is_instance_ownerattribute on form and add a note. (instance owner has to be seeded)Outstanding Questions, Concerns and Other Notes
It's quite possible i'm completely misunderstanding the intention of
current_organization!@maebeale, how does this align with your initial/current thinking?
Accessibility
This does make it harder for admins to change which org is the instance owner. If that becomes a needed feature, we can add a 'transfer ownership' feature.
Pre-Merge Checklist