Skip to content

Resolves #52 Case contact screen update#53

Merged
xihai01 merged 6 commits intorubyforpeace:mainfrom
michaelruhl:main
Jun 26, 2023
Merged

Resolves #52 Case contact screen update#53
xihai01 merged 6 commits intorubyforpeace:mainfrom
michaelruhl:main

Conversation

@michaelruhl
Copy link
Copy Markdown
Contributor

Resolves #52
XRecorder_21062023_214909.mp4

fixes case contact screen bugs, adds screen transitions and redux for data persistence.

@xihai01

@xihai01 xihai01 added UI bug Something isn't working labels Jun 22, 2023
@xihai01
Copy link
Copy Markdown
Collaborator

xihai01 commented Jun 22, 2023

can you make sure all the navigation strings are updated?

@michaelruhl
Copy link
Copy Markdown
Contributor Author

can you make sure all the navigation strings are updated?

do you mean the strings in App.tsx? like loginFlow, accountFlow etc?

@xihai01
Copy link
Copy Markdown
Collaborator

xihai01 commented Jun 23, 2023

can you make sure all the navigation strings are updated?

do you mean the strings in App.tsx? like loginFlow, accountFlow etc?

I mean make sure all navigate() methods in the files, including tests are updated/have with the correct strings

@michaelruhl
Copy link
Copy Markdown
Contributor Author

can you make sure all the navigation strings are updated?

do you mean the strings in App.tsx? like loginFlow, accountFlow etc?

I mean make sure all navigate() methods in the files, including tests are updated/have with the correct strings

ah, they are okay I actually did not change them at all from when you made your last push. only changes i made to App.tsx were adding transitions. As you can see all tests are passing~

@xihai01 xihai01 self-requested a review June 26, 2023 19:37
Copy link
Copy Markdown
Collaborator

@xihai01 xihai01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xihai01 xihai01 merged commit 69618ac into rubyforpeace:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants