This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Fixes to ERB comments#260
Merged
wingrunr21 merged 2 commits intomasterfrom Feb 5, 2018
Merged
Conversation
This allows the fix attempted in #224 to still work while also supporting proper ERB comments
This was referenced Feb 4, 2018
|
How do you apply this? I've already added multiple script snippets to the User Settings with positive results before, just these snippets I can't for the life of me figure out where to put them.. I've tried multiple places/ways of adding them (as you often do in frustration), still to no avail. screenshot below to show my current modifications that work as well as my query of desperation to try and find the lines you seem to have :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes done in #224 so that commenting in ERB files again works correctly (resolving #255). In addition, it specifies the
embeddedLanguageskey on the ERB language grammar definition that allows VSCode to assign a different language scope for embedded languages. This PR specifies that Ruby, CSS, and JS can be embedded in ERB.